[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 12/50] ps2: don't use vmstate_register() in ps2_kbd_init()
From: |
Mark Cave-Ayland |
Subject: |
[PATCH 12/50] ps2: don't use vmstate_register() in ps2_kbd_init() |
Date: |
Sun, 22 May 2022 19:17:58 +0100 |
Since PS2_KBD_DEVICE is a qdev device then vmstate_ps2_keyboard can be
registered
using the DeviceClass vmsd field instead. There is no need to use
qdev_set_legacy_instance_id() to ensure migration compatibility since the first
2
parameters to vmstate_register() are NULL and 0 respectively.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/input/ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 1d223de59f..04360c7f74 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -1232,7 +1232,6 @@ void *ps2_kbd_init(void (*update_irq)(void *, int), void
*update_arg)
trace_ps2_kbd_init(s);
ps2->update_irq = update_irq;
ps2->update_arg = update_arg;
- vmstate_register(NULL, 0, &vmstate_ps2_keyboard, s);
return s;
}
@@ -1274,6 +1273,7 @@ static void ps2_kbd_class_init(ObjectClass *klass, void
*data)
dc->realize = ps2_kbd_realize;
device_class_set_parent_reset(dc, ps2_kbd_reset, &ps2dc->parent_reset);
+ dc->vmsd = &vmstate_ps2_keyboard;
}
static const TypeInfo ps2_kbd_info = {
--
2.20.1
- [PATCH 00/50] PS2 device QOMification - part 1, Mark Cave-Ayland, 2022/05/22
- [PATCH 02/50] ps2: QOMify PS2State, Mark Cave-Ayland, 2022/05/22
- [PATCH 03/50] ps2: QOMify PS2KbdState, Mark Cave-Ayland, 2022/05/22
- [PATCH 01/50] ps2: checkpatch fixes, Mark Cave-Ayland, 2022/05/22
- [PATCH 04/50] ps2: QOMify PS2MouseState, Mark Cave-Ayland, 2022/05/22
- [PATCH 06/50] ps2: improve function prototypes in ps2.c and ps2.h, Mark Cave-Ayland, 2022/05/22
- [PATCH 05/50] ps2: move QOM type definitions from ps2.c to ps2.h, Mark Cave-Ayland, 2022/05/22
- [PATCH 08/50] ps2: implement ps2_reset() for the PS2_DEVICE QOM type based upon ps2_common_reset(), Mark Cave-Ayland, 2022/05/22
- [PATCH 07/50] ps2: introduce PS2DeviceClass, Mark Cave-Ayland, 2022/05/22
- [PATCH 12/50] ps2: don't use vmstate_register() in ps2_kbd_init(),
Mark Cave-Ayland <=
- [PATCH 10/50] ps2: implement ps2_kbd_realize() and use it to register ps2_keyboard_handler, Mark Cave-Ayland, 2022/05/22
- [PATCH 09/50] ps2: remove duplicate setting of scancode_set in ps2_kbd_init(), Mark Cave-Ayland, 2022/05/22
- [PATCH 11/50] ps2: implement ps2_mouse_realize() and use it to register ps2_mouse_handler, Mark Cave-Ayland, 2022/05/22
- [PATCH 14/50] pl050: checkpatch fixes, Mark Cave-Ayland, 2022/05/22
- [PATCH 13/50] ps2: don't use vmstate_register() in ps2_mouse_init(), Mark Cave-Ayland, 2022/05/22
- [PATCH 15/50] pl050: split pl050_update_irq() into separate pl050_set_irq() and pl050_update_irq() functions, Mark Cave-Ayland, 2022/05/22
- [PATCH 16/50] lasips2: spacing fixes, Mark Cave-Ayland, 2022/05/22
- [PATCH 17/50] lasips2: rename ps2dev_update_irq() to lasips2_port_set_irq(), Mark Cave-Ayland, 2022/05/22