Re: [PATCH] tests/avocado: Prefer max cpu type when using AArch64 virt machine

[Richard Henderson]

On 6/3/22 08:05, Andrew Jones wrote:
> On Fri, Jun 03, 2022 at 06:56:41AM -0700, Richard Henderson wrote:
> > On 6/3/22 02:25, Andrew Jones wrote:
> > > The max cpu type is the best default cpu type for tests to use
> > > when specifying the cpu type for AArch64 mach-virt. Switch all
> > > tests to it.
> >
> > This won't work without further changes.
> >
> > > @@ -147,7 +147,7 @@ def test_aarch64_virt(self):
> > >            """
> > >            :avocado: tags=arch:aarch64
> > >            :avocado: tags=machine:virt
> > > -        :avocado: tags=cpu:cortex-a53
> > > +        :avocado: tags=cpu:max
> > >            """
> > >            kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
> > >                          
> > > '/linux/releases/29/Everything/aarch64/os/images/pxeboot'
> >
> > For a release this old, we'll see the kernel bugs wrt FEAT_LPA/FEAT_LPA2.
> > See 11593544df6f ("tests/avocado: update aarch64_virt test to exercise -cpu 
> > max")
>
> Thanks Richard. How about for each test with guest kernels which don't
> work, I add a comment about LPA2 and use '-cpu max,lpa2=off' instead?

I would prefer to test new kernels with max, where we might actually test the newer 
features.  Perhaps keep one older kernel test around, to make sure we don't regress, but 
don't pretend that it can test more than what it was built for.


r~