qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/4] xlnx-zcu102: fix the display port.


From: Peter Maydell
Subject: Re: [PATCH v3 0/4] xlnx-zcu102: fix the display port.
Date: Mon, 6 Jun 2022 11:19:48 +0100

On Wed, 1 Jun 2022 at 18:24, <frederic.konrad@xilinx.com> wrote:
>
> From: Frederic Konrad <fkonrad@amd.com>
>
> Hi,
>
> This patch set fixes some issues with the DisplayPort for the ZCU102:
>
> The first patch fixes the wrong register size and thus the risk of register
> overflow.
>
> The three other one add a vblank interrupt required by the linux driver:
>   - When using the VNC graphic backend and leaving it unconnected, in the best
>     case the gfx_update callback is called once every 3000ms which is
>     insufficient for the driver.  This is fixed by providing a VBLANK 
> interrupt
>     from a ptimer.
>   - This requirement revealed two issues with the IRQ numbers and the
>     interrupt disable logic fixed by the two last patches.
>
> Tested by:
>   - booting Petalinux with the framebuffer enabled.
>   - migrating the running guest and ensure that the vblank timer still fire 
> correctly.

Hi; you forgot to bump the version_id in the vmstate struct when you
added the new field. Since that was the only problem, I've taken the
series into target-arm.next and made that change there. I also added
a note to the commit message that this is a migration break for the
xlnx-zcu102 board.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]