Re: [PATCH 23/71] target/arm: Add syn_smetrap

[Peter Maydell]

On Thu, 2 Jun 2022 at 23:04, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This will be used for raising various traps for SME.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/syndrome.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> +static inline uint32_t syn_smetrap(SMEExceptionType etype, bool is_16bit)
> +{
> +    return (EC_SMETRAP << ARM_EL_EC_SHIFT) | (!is_16bit * ARM_EL_IL) | etype;

Every other syn_* function handles the is_16bit argument as
"(is_16bit ? 0 : ARM_EL_IL)" -- can we do that same here, please?

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM