Re: [PATCH 21/71] target/arm: Implement TPIDR2_EL0

[Richard Henderson]

On 6/6/22 06:18, Peter Maydell wrote:
> > +        if (!(sctlr & SCTLR_EnTP2)) {
> > +            uint64_t hcr = arm_hcr_el2_eff(env);
> > +            return hcr & HCR_TGE ? CP_ACCESS_TRAP_EL2 : CP_ACCESS_TRAP;
>
> Do we really need to do this rather than just returning
> CP_ACCESS_TRAP and letting the "take trap to EL2 if TGE
> enabled" check in raise_exception() do the TGE routing?

No, you're right.

r~