Re: [PATCH 11/21] test/avocado/machine_aspeed.py: Add an I2C RTC test

[Joel Stanley]

On Mon, 6 Jun 2022 at 15:08, Cédric Le Goater <clg@kaod.org> wrote:
>
> Add a RTC device on bus 15 and check that the ouput of the hwclock

spelling: output

> command matches the current year.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
>  tests/avocado/machine_aspeed.py | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed.py
> index a3b4b9e5093c..28b8a4c8124b 100644
> --- a/tests/avocado/machine_aspeed.py
> +++ b/tests/avocado/machine_aspeed.py
> @@ -136,10 +136,18 @@ def test_arm_ast2600_evb_builroot(self):
>
>          self.vm.add_args('-device',
>                           'tmp423,bus=aspeed.i2c.bus.15,address=0x4c');
> +        self.vm.add_args('-device',
> +                         'ds1338,bus=aspeed.i2c.bus.15,address=0x32');

Is there any value running this on the 2400 and 2500 machine types
too? They all use the same model so perhaps not?

>          self.do_test_arm_aspeed_buidroot_start(image_path, '0xf00')
>          exec_command_and_wait_for_pattern(self,
>                                            'i2cget -y 15 0x4c 0xff', '0x23');
>          exec_command_and_wait_for_pattern(self,
>                                            'i2cget -y 15 0x4c 0xfe', '0x55');
>
> +        exec_command_and_wait_for_pattern(self,
> +             'echo ds1307 0x32 > 
> /sys/class/i2c-dev/i2c-15/device/new_device',
> +             'i2c i2c-15: new_device: Instantiated device ds1307 at 0x32');
> +        year = time.strftime("%Y")
> +        exec_command_and_wait_for_pattern(self, 'hwclock -f /dev/rtc1', 
> year);
> +
>          self.do_test_arm_aspeed_buidroot_poweroff()
> --
> 2.35.3
>