|
From: | Thomas Huth |
Subject: | Re: [PATCH] disas: Remove libvixl disassembler |
Date: | Thu, 9 Jun 2022 10:47:24 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 |
On 08/06/2022 17.51, Paolo Bonzini wrote:
On 6/3/22 19:35, Thomas Huth wrote:On 03/06/2022 19.26, Claudio Fontana wrote:On 6/3/22 18:42, Thomas Huth wrote:The disassembly via capstone should be superiour to our old vixl sources nowadays, so let's finally cut this old disassembler out of the QEMU source tree. Signed-off-by: Thomas Huth <thuth@redhat.com>agreed, one thought: at the time I added this thing, I had to add C++ compilation support,maybe something we can now drop if there are no more C++ users?I thought about that, too, but we still have disas/nanomips.cpp left and the Windows-related files in qga/vss-win32/* .That is pure C++ so it does not need the extra complication of "detect whether the C and C++ compiler are ABI-compatible" (typically due to different libasan/libtsan implementation between gcc and clang). So it's really just nanoMIPS that's left.
Ok, so the next theoretical question is: If we get rid of the nanomips.cpp file or convert it to plain C, would we then simplify the code in configure again (and forbid C++ for the main QEMU code), or would we rather keep the current settings in case we want to re-introduce more C++ code again in the future?
Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |