qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 35/71] target/arm: Move arm_cpu_*_finalize to internals.h


From: Peter Maydell
Subject: Re: [PATCH v2 35/71] target/arm: Move arm_cpu_*_finalize to internals.h
Date: Thu, 9 Jun 2022 16:31:57 +0100

On Tue, 7 Jun 2022 at 21:33, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Drop the aa32-only inline fallbacks,
> and just use a couple of ifdefs.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/cpu.h       | 6 ------
>  target/arm/internals.h | 3 +++
>  target/arm/cpu.c       | 2 ++
>  3 files changed, 5 insertions(+), 6 deletions(-)

I'm not a huge fan of ifdefs in functions, but I guess so.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]