Re: [PATCH v2 41/71] target/arm: Add infrastructure for disas_sme

[Richard Henderson]

On 6/9/22 08:35, Peter Maydell wrote:
> > +        if (!disas_sme(s, insn)) {
> > +            unallocated_encoding(s);
> > +        }
> > +        break;
>
> I still think we should check bit 31 here.

We don't do anything similar over in a32, where we've done the full conversion:

        if (disas_a32_uncond(s, insn) ||

            disas_vfp_uncond(s, insn) ||

            disas_neon_dp(s, insn) ||

            disas_neon_ls(s, insn) ||

            disas_neon_shared(s, insn)) {

            return;

        }


and there's nothing else within major opcode 0 to conflict.

But if you insist, ok.


r~