Re: [PATCH] target/arm: Catch invalid kvm state also for hvf

[Richard Henderson]

On 6/20/22 09:08, Alexander Graf wrote:
> -    if (kvm_enabled()) {
> +    if (kvm_enabled() || hvf_enabled()) {

I think this should be !tcg_enabled().  No hw virtualization can use EL3 (or M-profile), 
only full emulation from TCG.  There is such a thing as ARM on Windows, so I can imagine 
that WHPX may make a future appearance here.

(MTE may eventually be supported by virtualization, but it's not there yet.)


>          if (arm_feature(env, ARM_FEATURE_M)) {
>              error_setg(errp,
> -                       "Cannot enable KVM when using an M-profile guest CPU");
> +                       "Cannot enable KVM or HVF when using an M-profile guest 
> CPU");
>              return;
>          }

You can get the accelerator name from

    AccelClass *ac = ACCEL_GET_CLASS(current_accel());
    const char *name = ac->name;


r~