[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 36/54] pl050: switch over from update_irq() function to PS
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 36/54] pl050: switch over from update_irq() function to PS2 device gpio |
Date: |
Fri, 24 Jun 2022 16:08:22 +0100 |
On Fri, 24 Jun 2022 at 14:43, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> Add a new pl050_init() function which initialises a qdev input gpio for
> handling
> incoming PS2 IRQs, and then wire up the PS2 device to use it. At the same time
> set update_irq() and update_arg to NULL in ps2_kbd_init() and ps2_mouse_init()
> to ensure that any accidental attempt to use the legacy update_irq() function
> will
> cause a NULL pointer dereference.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Acked-by: Helge Deller <deller@gmx.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 30/54] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i8042_mmio_realize(), (continued)
- [PATCH v2 30/54] pckbd: move ps2_kbd_init() and ps2_mouse_init() to i8042_mmio_realize(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 31/54] ps2: make ps2_raise_irq() function static, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 32/54] ps2: use ps2_raise_irq() instead of calling update_irq() directly, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 33/54] ps2: introduce ps2_lower_irq() instead of calling update_irq() directly, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 34/54] ps2: add gpio for output IRQ and optionally use it in ps2_raise_irq() and ps2_lower_irq(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 35/54] pckbd: replace irq_kbd and irq_mouse with qemu_irq array in KBDState, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 38/54] lasips2: QOMify LASIPS2State, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 37/54] pl050: add QEMU interface comment, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 36/54] pl050: switch over from update_irq() function to PS2 device gpio, Mark Cave-Ayland, 2022/06/24
- Re: [PATCH v2 36/54] pl050: switch over from update_irq() function to PS2 device gpio,
Peter Maydell <=
- [PATCH v2 39/54] lasips2: move lasips2 QOM types from lasips2.c to lasips2.h, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 40/54] lasips2: rename lasips2_init() to lasips2_initfn() and update it to return the LASIPS2 device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 41/54] lasips2: implement lasips2_init() function, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 43/54] lasips2: move initialisation of PS2 ports from lasi_initfn() to lasi_init(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 45/54] lasips2: implement lasips2_realize(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 42/54] lasips2: move mapping of LASIPS2 registers to HPPA machine, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 46/54] lasips2: use sysbus IRQ for output IRQ, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 47/54] lasips2: switch over from update_irq() function to PS2 device gpio, Mark Cave-Ayland, 2022/06/24