[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 47/54] lasips2: switch over from update_irq() function to
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 47/54] lasips2: switch over from update_irq() function to PS2 device gpio |
Date: |
Fri, 24 Jun 2022 16:10:51 +0100 |
On Fri, 24 Jun 2022 at 14:44, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> Add a qdev gpio input in lasips2_init() by taking the existing
> lasips2_port_set_irq()
> function, updating it accordingly and then renaming to lasips2_set_irq(). Use
> these
> new qdev gpio inputs to wire up the PS2 keyboard and mouse devices.
>
> At the same time set update_irq() and update_arg to NULL in ps2_kbd_init() and
> ps2_mouse_init() to ensure that any accidental attempt to use the legacy
> update_irq()
> function will cause a NULL pointer dereference.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Acked-by: Helge Deller <deller@gmx.de>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v2 36/54] pl050: switch over from update_irq() function to PS2 device gpio, (continued)
- [PATCH v2 39/54] lasips2: move lasips2 QOM types from lasips2.c to lasips2.h, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 40/54] lasips2: rename lasips2_init() to lasips2_initfn() and update it to return the LASIPS2 device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 41/54] lasips2: implement lasips2_init() function, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 43/54] lasips2: move initialisation of PS2 ports from lasi_initfn() to lasi_init(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 45/54] lasips2: implement lasips2_realize(), Mark Cave-Ayland, 2022/06/24
- [PATCH v2 42/54] lasips2: move mapping of LASIPS2 registers to HPPA machine, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 46/54] lasips2: use sysbus IRQ for output IRQ, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 47/54] lasips2: switch over from update_irq() function to PS2 device gpio, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 48/54] lasips2: add QEMU interface comment, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 49/54] pckbd: switch I8042_MMIO device from update_irq() function to PS2 device gpio, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 44/54] lasips2: add base property, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 50/54] pckbd: add QEMU interface comment for I8042_MMIO device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 51/54] pckbd: add i8042_reset() function to I8042 device, Mark Cave-Ayland, 2022/06/24
- [PATCH v2 52/54] pckbd: switch I8042 device from update_irq() function to PS2 device gpio, Mark Cave-Ayland, 2022/06/24