Re: [PATCH 2/3] aspeed/i2c: Change trace event for NORMAL_STOP states

[Peter Delevoryas]

> On Jun 28, 2022, at 8:47 AM, Cédric Le Goater <clg@kaod.org> wrote:
> 
> Using a 'stop' string seems more appropriate than 'normal'.

Ha yes! This is an understatement, the change is much appreciated.

I've seen that trace and never realized it was referring to ‘stop’.

Reviewed-by: Peter Delevoryas <pdel@fb.com>

> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/i2c/aspeed_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
> index 37ae1f2e04bd..9b41bc38964f 100644
> --- a/hw/i2c/aspeed_i2c.c
> +++ b/hw/i2c/aspeed_i2c.c
> @@ -58,7 +58,7 @@ static inline void 
> aspeed_i2c_bus_raise_interrupt(AspeedI2CBus *bus)
>                ARRAY_FIELD_EX32(bus->regs, I2CD_INTR_STS, 
> SLAVE_ADDR_RX_MATCH) ?
>                                                "slave-match|" : "",
>                SHARED_ARRAY_FIELD_EX32(bus->regs, reg_intr_sts, NORMAL_STOP) ?
> -                                               "normal|" : "",
> +                                               "stop|" : "",
>                SHARED_ARRAY_FIELD_EX32(bus->regs, reg_intr_sts, ABNORMAL) ?
>                                                "abnormal"  : "");
> 
> -- 
> 2.35.3
> 
>