[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO no
From: |
Jean-Philippe Brucker |
Subject: |
Re: [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO node |
Date: |
Thu, 1 Sep 2022 15:59:55 +0100 |
On Wed, Aug 24, 2022 at 08:48:26PM +0100, Peter Maydell wrote:
> On Wed, 24 Aug 2022 at 16:51, Jean-Philippe Brucker
> <jean-philippe@linaro.org> wrote:
> >
> > The GPIO devicetree node is missing "interrupt-controller" and
> > "#interrupt-cells" properties:
> >
> > pl061@9030000: 'interrupt-controller' is a required property
> > From schema: linux/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
> > pl061@9030000: '#interrupt-cells' is a required property
> > From schema: linux/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
>
> Why? This is a GPIO controller, not an interrupt controller.
> It seems wrong to be advertising in the dtb that it is.
pl061 can be used as an interrupt controller, and I think it's wired that
way, with GPIO key acting as an interrupt source. I'll add this to the
commit message.
Thanks,
Jean
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO node,
Jean-Philippe Brucker <=