Re: [PATCH 1/3] arm: move KVM breakpoints helpers

[Philippe Mathieu-Daudé]

On 7/11/22 15:15, Alex Bennée wrote:
> francesco.cagnin@gmail.com writes:
>
> > From: Francesco Cagnin <fcagnin@quarkslab.com>
> >
> > These helpers will be also used for HVF. Aside from reformatting a
> > couple of comments for 'checkpatch.pl', this is just code motion.
> >
> > Signed-off-by: Francesco Cagnin <fcagnin@quarkslab.com>
> > ---
> >   target/arm/debug_helper.c | 241 +++++++++++++++++++++++++++++++++
> >   target/arm/internals.h    |  50 +++++++
>
> Moving out of kvm64.c seems fine to me but I wonder if debug_helper.c is
> the best location. debug_helpers is currently very focused on just
> handling the TCG emulation case where as we are doing this tracking just
> for the VMM cases or KVM and now HVF.
>
> We are (slowly) trying to clean up the code in target/arm so we can
> support builds like --disable-tcg and to do that we want to avoid too
> much ifdef hackery in the individual compilation units.


I was planning to move hypervisor-specific code to 
target/arm/$hypervisor/, but here Francesco wants to re-use the same code
between 2 hypervisors... Maybe move it to target/arm/hyp_gdbstub.c
and let meson add it conditionally?

> >   target/arm/kvm64.c        | 276 --------------------------------------
> >   3 files changed, 291 insertions(+), 276 deletions(-)
> <snip>