[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/9] Python/iotests: Add type hint for nbd module
From: |
John Snow |
Subject: |
[PULL 1/9] Python/iotests: Add type hint for nbd module |
Date: |
Wed, 4 Oct 2023 15:46:05 -0400 |
The test bails gracefully if this module isn't installed, but linters
need a little help understanding that. It's enough to just declare the
type in this case.
(Fixes pylint complaining about use of an uninitialized variable because
it isn't wise enough to understand the notrun call is noreturn.)
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/tests/nbd-multiconn | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/tests/nbd-multiconn
b/tests/qemu-iotests/tests/nbd-multiconn
index 478a1eaba27..7e686a786ea 100755
--- a/tests/qemu-iotests/tests/nbd-multiconn
+++ b/tests/qemu-iotests/tests/nbd-multiconn
@@ -20,6 +20,8 @@
import os
from contextlib import contextmanager
+from types import ModuleType
+
import iotests
from iotests import qemu_img_create, qemu_io
@@ -28,7 +30,7 @@ disk = os.path.join(iotests.test_dir, 'disk')
size = '4M'
nbd_sock = os.path.join(iotests.sock_dir, 'nbd_sock')
nbd_uri = 'nbd+unix:///{}?socket=' + nbd_sock
-
+nbd: ModuleType
@contextmanager
def open_nbd(export_name):
--
2.41.0
- [PULL 0/9] Python patches, John Snow, 2023/10/04
- [PULL 4/9] python/console_socket: accept existing FD in initializer, John Snow, 2023/10/04
- [PULL 2/9] python/machine: move socket setup out of _base_args property, John Snow, 2023/10/04
- [PULL 3/9] python/machine: close sock_pair in cleanup path, John Snow, 2023/10/04
- [PULL 5/9] python/machine: use socketpair() for console connections, John Snow, 2023/10/04
- [PULL 8/9] python/qmp: remove Server.wait_closed() call for Python 3.12, John Snow, 2023/10/04
- [PULL 7/9] python/machine: remove unused sock_dir argument, John Snow, 2023/10/04
- [PULL 9/9] Python: test Python 3.12, John Snow, 2023/10/04
- [PULL 6/9] python/machine: use socketpair() for qtest connection, John Snow, 2023/10/04
- [PULL 1/9] Python/iotests: Add type hint for nbd module,
John Snow <=
- Re: [PULL 0/9] Python patches, Philippe Mathieu-Daudé, 2023/10/05