[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/13] virtio-iommu: Consolidate host reserved regions and pro
From: |
Eric Auger |
Subject: |
[PATCH v3 11/13] virtio-iommu: Consolidate host reserved regions and property set ones |
Date: |
Wed, 11 Oct 2023 19:52:27 +0200 |
Up to now we were exposing to the RESV_MEM probe requests the
reserved memory regions set though the reserved-regions array property.
Combine those with the host reserved memory regions if any. Those
latter are tagged as RESERVED. We don't have more information about
them besides then cannot be mapped. Reserved regions set by
property have higher priority.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
hw/virtio/virtio-iommu.c | 36 ++++++++++++++++++++++++++++++++++++
hw/virtio/trace-events | 1 +
2 files changed, 37 insertions(+)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 15aadd6fdd..dede0d41aa 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -21,6 +21,7 @@
#include "qemu/log.h"
#include "qemu/iov.h"
#include "qemu/range.h"
+#include "qemu/reserved-region.h"
#include "exec/target_page.h"
#include "hw/qdev-properties.h"
#include "hw/virtio/virtio.h"
@@ -1156,6 +1157,40 @@ static int
virtio_iommu_set_page_size_mask(IOMMUMemoryRegion *mr,
return 0;
}
+/**
+ * rebuild_resv_regions: rebuild resv regions with both the
+ * info of host resv ranges and property set resv ranges
+ */
+static int rebuild_resv_regions(IOMMUDevice *sdev)
+{
+ GList *l;
+ int i = 0;
+
+ /* free the existing list and rebuild it from scratch */
+ g_list_free_full(sdev->resv_regions, g_free);
+ sdev->resv_regions = NULL;
+
+ /* First add host reserved regions if any, all tagged as RESERVED */
+ for (l = sdev->host_resv_ranges; l; l = l->next) {
+ ReservedRegion *reg = g_new0(ReservedRegion, 1);
+ Range *r = (Range *)l->data;
+
+ reg->type = VIRTIO_IOMMU_RESV_MEM_T_RESERVED;
+ range_set_bounds(®->range, range_lob(r), range_upb(r));
+ sdev->resv_regions = resv_region_list_insert(sdev->resv_regions, reg);
+ trace_virtio_iommu_host_resv_regions(sdev->iommu_mr.parent_obj.name, i,
+ range_lob(®->range),
+ range_upb(®->range));
+ i++;
+ }
+ /*
+ * then add higher priority reserved regions set by the machine
+ * through properties
+ */
+ add_prop_resv_regions(sdev);
+ return 0;
+}
+
/**
* virtio_iommu_set_iova_ranges: Conveys the usable IOVA ranges
*
@@ -1211,6 +1246,7 @@ static int virtio_iommu_set_iova_ranges(IOMMUMemoryRegion
*mr,
range_inverse_array(iova_ranges,
&sdev->host_resv_ranges,
0, UINT64_MAX);
+ rebuild_resv_regions(sdev);
return 0;
error:
diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index 1cb9027d1e..b49d9c4b0a 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -134,6 +134,7 @@ virtio_iommu_notify_flag_add(const char *name) "add
notifier to mr %s"
virtio_iommu_notify_flag_del(const char *name) "del notifier from mr %s"
virtio_iommu_switch_address_space(uint8_t bus, uint8_t slot, uint8_t fn, bool
on) "Device %02x:%02x.%x switching address space (iommu enabled=%d)"
virtio_iommu_freeze_granule(uint64_t page_size_mask) "granule set to 0x%"PRIx64
+virtio_iommu_host_resv_regions(const char *name, uint32_t index, uint64_t lob,
uint64_t upb) "mr=%s host-resv-reg[%d] = [0x%"PRIx64",0x%"PRIx64"]"
# virtio-mem.c
virtio_mem_send_response(uint16_t type) "type=%" PRIu16
--
2.41.0
- [PATCH v3 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space, Eric Auger, 2023/10/11
- [PATCH v3 01/13] memory: Let ReservedRegion use Range, Eric Auger, 2023/10/11
- [PATCH v3 02/13] memory: Introduce memory_region_iommu_set_iova_ranges, Eric Auger, 2023/10/11
- [PATCH v3 05/13] range: Make range_compare() public, Eric Auger, 2023/10/11
- [PATCH v3 03/13] vfio: Collect container iova range info, Eric Auger, 2023/10/11
- [PATCH v3 04/13] virtio-iommu: Rename reserved_regions into prop_resv_regions, Eric Auger, 2023/10/11
- [PATCH v3 07/13] virtio-iommu: Introduce per IOMMUDevice reserved regions, Eric Auger, 2023/10/11
- [PATCH v3 11/13] virtio-iommu: Consolidate host reserved regions and property set ones,
Eric Auger <=
- [PATCH v3 08/13] range: Introduce range_inverse_array(), Eric Auger, 2023/10/11
- [PATCH v3 09/13] virtio-iommu: Record whether a probe request has been issued, Eric Auger, 2023/10/11
- [PATCH v3 12/13] test: Add some tests for range and resv-mem helpers, Eric Auger, 2023/10/11
- [PATCH v3 06/13] util/reserved-region: Add new ReservedRegion helpers, Eric Auger, 2023/10/11
- [PATCH v3 13/13] vfio: Remove 64-bit IOVA address space assumption, Eric Auger, 2023/10/11
- [PATCH v3 10/13] virtio-iommu: Implement set_iova_ranges() callback, Eric Auger, 2023/10/11
- Re: [PATCH v3 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space, Michael S. Tsirkin, 2023/10/18