Re: [RFC PATCH 48/78] contrib/vhost-user-scsi: add fallthrough pseudo-keyword

[Raphael Norwitz]

> On Oct 13, 2023, at 3:48 AM, Emmanouil Pitsidianakis 
> <manos.pitsidianakis@linaro.org> wrote:
> 
> In preparation of raising -Wimplicit-fallthrough to 5, replace all
> fall-through comments with the fallthrough attribute pseudo-keyword.
> 
> Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>

Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>

> ---
> contrib/vhost-user-scsi/vhost-user-scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c 
> b/contrib/vhost-user-scsi/vhost-user-scsi.c
> index 9ef61cf5a7..71076f579b 100644
> --- a/contrib/vhost-user-scsi/vhost-user-scsi.c
> +++ b/contrib/vhost-user-scsi/vhost-user-scsi.c
> @@ -109,14 +109,15 @@ static struct scsi_task *scsi_task_new(int cdb_len, 
> uint8_t *cdb, int dir,
> static int get_cdb_len(uint8_t *cdb)
> {
>     assert(cdb);
> 
>     switch (cdb[0] >> 5) {
>     case 0: return 6;
> -    case 1: /* fall through */
> +    case 1:
> +            fallthrough;
>     case 2: return 10;
>     case 4: return 16;
>     case 5: return 12;
>     }
>     g_warning("Unable to determine cdb len (0x%02hhX)", (uint8_t)(cdb[0] >> 
> 5));
>     return -1;
> }
> -- 
> 2.39.2
>