[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] misc/led: LED state is set opposite of what is expected
From: |
Glenn Miles |
Subject: |
[PATCH] misc/led: LED state is set opposite of what is expected |
Date: |
Tue, 24 Oct 2023 12:39:23 -0500 |
Testing of the LED state showed that when the LED polarity was
set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on
the input GPIO of the LED, the LED was being turned off when it was
expected to be turned on.
Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
---
hw/misc/led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/led.c b/hw/misc/led.c
index f6d6d68bce..96cad7578e 100644
--- a/hw/misc/led.c
+++ b/hw/misc/led.c
@@ -63,7 +63,7 @@ static void led_set_state_gpio_handler(void *opaque, int
line, int new_state)
LEDState *s = LED(opaque);
assert(line == 0);
- led_set_state(s, !!new_state != s->gpio_active_high);
+ led_set_state(s, !new_state != s->gpio_active_high);
}
static void led_reset(DeviceState *dev)
--
2.31.1
- [PATCH] misc/led: LED state is set opposite of what is expected,
Glenn Miles <=