[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events |
|
Date: |
Mon, 30 Oct 2023 04:23:54 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 |
Hi Bernhard,
On 28/10/23 14:24, Bernhard Beschow wrote:
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/misc/imx6_ccm.c | 41 ++++++++++++++---------------------------
hw/misc/trace-events | 15 +++++++++++++++
2 files changed, 29 insertions(+), 27 deletions(-)
+# imx6_ccm.c
+imx6_analog_get_periph_clk(uint32_t freq) "freq = %u"
Preferably explicit the unit, as "freq = %u Hz".
+imx6_analog_get_pll2_clk(uint32_t freq) "freq = %u"
+imx6_analog_get_pll2_pfd0_clk(uint32_t freq) "freq = %u"
+imx6_analog_get_pll2_pfd2_clk(uint32_t freq) "freq = %u"
+imx6_ccm_get_ahb_clk(uint32_t freq) "freq = %u"
+imx6_ccm_get_ipg_clk(uint32_t freq) "freq = %u"
+imx6_ccm_get_per_clk(uint32_t freq) "freq = %u"
+imx6_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(Clock = %d) = %u"
'freq' is uint64_t, but I suppose 32-bit is enough, so I'm
not against the implicit cast.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
- [PATCH 0/6] Various tracing patches, Bernhard Beschow, 2023/10/28
- [PATCH 1/6] hw/watchdog/wdt_imx2: Trace MMIO access, Bernhard Beschow, 2023/10/28
- [PATCH 2/6] hw/watchdog/wdt_imx2: Trace timer activity, Bernhard Beschow, 2023/10/28
- [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events, Bernhard Beschow, 2023/10/28
- Re: [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events,
Philippe Mathieu-Daudé <=
- [PATCH 5/6] hw/i2c/pm_smbus: Convert DPRINTF to trace events, Bernhard Beschow, 2023/10/28
- [PATCH 3/6] hw/misc/imx7_snvs: Trace MMIO access, Bernhard Beschow, 2023/10/28
- [PATCH 6/6] system/memory: Trace names of MemoryRegions rather than host pointers, Bernhard Beschow, 2023/10/28
- Re: [PATCH 0/6] Various tracing patches, Peter Maydell, 2023/10/31