Re: [PATCH 08/22] gdbstub: Add num_regs member to GDBFeature

[Philippe Mathieu-Daudé]

On 7/11/23 11:24, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > Hi Alex,
> >
> > On 6/11/23 19:50, Alex Bennée wrote:
> > > From: Akihiko Odaki <akihiko.odaki@daynix.com>
> > > Currently the number of registers exposed to GDB is written as magic
> > > numbers in code. Derive the number of registers GDB actually see from
> > > XML files to replace the magic numbers in code later.
> > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> > > Message-Id: <20231025093128.33116-2-akihiko.odaki@daynix.com>
> >
> > Something in your workflow is odd, you should keep this Message-Id,
> >
> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > > Message-Id: <20231103195956.1998255-9-alex.bennee@linaro.org>
> >
> > and not propagate this one, IMO.
>
> Why not - it tracks all the review stuff. I explicitly keep on
> Message-Id per domain so we see the original posting and the last time
> it was posted (which you can then follow the chain of reviews from
> there).
>
> If we want to have an explicit policy on which Message-Id's to keep then
> we should document it.

Fair enough :)