[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate(
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate() calls |
Date: |
Mon, 20 Nov 2023 22:32:38 +0100 |
Mechanical change using the following coccinelle script:
@@
expression mr, owner, arg3, arg4, errp;
@@
- memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp);
if (
- errp
+ !memory_region_init_rom_nomigrate(mr, owner, arg3, arg4, &errp)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
system/memory.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/system/memory.c b/system/memory.c
index bfe0b62d59..2fe4c3861b 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -3628,11 +3628,8 @@ void memory_region_init_rom(MemoryRegion *mr,
Error **errp)
{
DeviceState *owner_dev;
- Error *err = NULL;
- memory_region_init_rom_nomigrate(mr, owner, name, size, &err);
- if (err) {
- error_propagate(errp, err);
+ if (!memory_region_init_rom_nomigrate(mr, owner, name, size, errp)) {
return;
}
/* This will assert if owner is neither NULL nor a DeviceState.
--
2.41.0
- [PATCH-for-9.0 00/25] memory: Propagate Error* when possible, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 01/25] memory: Have memory_region_init_ram_flags_nomigrate() return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 02/25] memory: Have memory_region_init_ram_nomigrate() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 03/25] memory: Have memory_region_init_rom_nomigrate() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 04/25] memory: Simplify memory_region_init_rom_nomigrate() calls,
Philippe Mathieu-Daudé <=
- [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 06/25] memory: Have memory_region_init_ram() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 07/25] memory: Have memory_region_init_rom() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 09/25] memory: Simplify memory_region_init_rom_device_nomigrate() calls, Philippe Mathieu-Daudé, 2023/11/20