[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-9.0 08/25] memory: Have memory_region_init_rom_device_nomigra
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-9.0 08/25] memory: Have memory_region_init_rom_device_nomigrate() return a boolean |
Date: |
Mon, 20 Nov 2023 22:32:42 +0100 |
Following the example documented since commit e3fe3988d7 ("error:
Document Error API usage rules"), have cpu_exec_realizefn()
return a boolean indicating whether an error is set or not.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/exec/memory.h | 4 +++-
system/memory.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 9d9798a527..e2cf3e58de 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1523,8 +1523,10 @@ bool memory_region_init_rom_nomigrate(MemoryRegion *mr,
* must be unique within any device
* @size: size of the region.
* @errp: pointer to Error*, to store an error if it happens.
+ *
+ * Return: true on success, else false setting @errp with error.
*/
-void memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
+bool memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
Object *owner,
const MemoryRegionOps *ops,
void *opaque,
diff --git a/system/memory.c b/system/memory.c
index 2c764947fa..1cccc4b755 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -1743,7 +1743,7 @@ bool memory_region_init_rom_nomigrate(MemoryRegion *mr,
return rv;
}
-void memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
+bool memory_region_init_rom_device_nomigrate(MemoryRegion *mr,
Object *owner,
const MemoryRegionOps *ops,
void *opaque,
@@ -1764,7 +1764,9 @@ void memory_region_init_rom_device_nomigrate(MemoryRegion
*mr,
mr->size = int128_zero();
object_unparent(OBJECT(mr));
error_propagate(errp, err);
+ return false;
}
+ return true;
}
void memory_region_init_iommu(void *_iommu_mr,
--
2.41.0
- [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls, (continued)
- [PATCH-for-9.0 05/25] memory: Simplify memory_region_init_ram_from_fd() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 06/25] memory: Have memory_region_init_ram() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 07/25] memory: Have memory_region_init_rom() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 09/25] memory: Simplify memory_region_init_rom_device_nomigrate() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 10/25] memory: Have memory_region_init_rom_device() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 08/25] memory: Have memory_region_init_rom_device_nomigrate() return a boolean,
Philippe Mathieu-Daudé <=
- [PATCH-for-9.0 11/25] memory: Have memory_region_init_resizeable_ram() return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 13/25] memory: Have memory_region_init_ram_from_fd() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 12/25] memory: Have memory_region_init_ram_from_file() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 14/25] backends: Use g_autofree in HostMemoryBackendClass::alloc() handlers, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 15/25] backends: Simplify host_memory_backend_memory_complete(), Philippe Mathieu-Daudé, 2023/11/20