[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls |
Date: |
Mon, 20 Nov 2023 22:32:53 +0100 |
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
backends/hostmem.c | 22 +++++++---------------
hw/virtio/virtio-mem.c | 6 ++----
2 files changed, 9 insertions(+), 19 deletions(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 1b0043a0d9..30f69b2cb5 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -219,7 +219,6 @@ static bool host_memory_backend_get_prealloc(Object *obj,
Error **errp)
static void host_memory_backend_set_prealloc(Object *obj, bool value,
Error **errp)
{
- Error *local_err = NULL;
HostMemoryBackend *backend = MEMORY_BACKEND(obj);
if (!backend->reserve && value) {
@@ -237,10 +236,8 @@ static void host_memory_backend_set_prealloc(Object *obj,
bool value,
void *ptr = memory_region_get_ram_ptr(&backend->mr);
uint64_t sz = memory_region_size(&backend->mr);
- qemu_prealloc_mem(fd, ptr, sz, backend->prealloc_threads,
- backend->prealloc_context, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
+ if (!qemu_prealloc_mem(fd, ptr, sz, backend->prealloc_threads,
+ backend->prealloc_context, errp)) {
return;
}
backend->prealloc = true;
@@ -398,16 +395,11 @@ host_memory_backend_memory_complete(UserCreatable *uc,
Error **errp)
* This is necessary to guarantee memory is allocated with
* specified NUMA policy in place.
*/
- if (backend->prealloc) {
- Error *local_err = NULL;
-
- qemu_prealloc_mem(memory_region_get_fd(&backend->mr), ptr, sz,
- backend->prealloc_threads,
- backend->prealloc_context, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
- return;
- }
+ if (backend->prealloc &&
!qemu_prealloc_mem(memory_region_get_fd(&backend->mr),
+ ptr, sz,
+ backend->prealloc_threads,
+ backend->prealloc_context,
errp)) {
+ return;
}
}
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index 75ee38aa46..12dc39e0b1 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -605,8 +605,7 @@ static int virtio_mem_set_block_state(VirtIOMEM *vmem,
uint64_t start_gpa,
int fd = memory_region_get_fd(&vmem->memdev->mr);
Error *local_err = NULL;
- qemu_prealloc_mem(fd, area, size, 1, NULL, &local_err);
- if (local_err) {
+ if (!qemu_prealloc_mem(fd, area, size, 1, NULL, &local_err)) {
static bool warned;
/*
@@ -1249,8 +1248,7 @@ static int virtio_mem_prealloc_range_cb(VirtIOMEM *vmem,
void *arg,
int fd = memory_region_get_fd(&vmem->memdev->mr);
Error *local_err = NULL;
- qemu_prealloc_mem(fd, area, size, 1, NULL, &local_err);
- if (local_err) {
+ if (!qemu_prealloc_mem(fd, area, size, 1, NULL, &local_err)) {
error_report_err(local_err);
return -ENOMEM;
}
--
2.41.0
- [PATCH-for-9.0 14/25] backends: Use g_autofree in HostMemoryBackendClass::alloc() handlers, (continued)
- [PATCH-for-9.0 14/25] backends: Use g_autofree in HostMemoryBackendClass::alloc() handlers, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 15/25] backends: Simplify host_memory_backend_memory_complete(), Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 17/25] backends: Reduce variable scope in host_memory_backend_memory_complete, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 16/25] backends: Have HostMemoryBackendClass::alloc() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 18/25] util/oslib: Have qemu_prealloc_mem() handler return a boolean, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls,
Philippe Mathieu-Daudé <=
- [PATCH-for-9.0 20/25] hw: Simplify memory_region_init_ram() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 21/25] hw/arm: Simplify memory_region_init_rom() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 22/25] hw/sparc: Simplify memory_region_init_ram_nomigrate() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 23/25] hw/misc: Simplify memory_region_init_ram_from_fd() calls, Philippe Mathieu-Daudé, 2023/11/20