[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-9.0 24/25] hw/nvram: Simplify memory_region_init_rom_device()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-9.0 24/25] hw/nvram: Simplify memory_region_init_rom_device() calls |
Date: |
Mon, 20 Nov 2023 22:32:58 +0100 |
Mechanical change using the following coccinelle script:
@@
expression mr, owner, arg3, arg4, arg5, arg6, errp;
@@
- memory_region_init_rom_device(mr, owner, arg3, arg4, arg5, arg6, &errp);
if (
- errp
+ !memory_region_init_rom_device(mr, owner, arg3, arg4, arg5, arg6, &errp)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/nvram/nrf51_nvm.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/nvram/nrf51_nvm.c b/hw/nvram/nrf51_nvm.c
index 7f1db8c423..7b25becd49 100644
--- a/hw/nvram/nrf51_nvm.c
+++ b/hw/nvram/nrf51_nvm.c
@@ -336,12 +336,9 @@ static void nrf51_nvm_init(Object *obj)
static void nrf51_nvm_realize(DeviceState *dev, Error **errp)
{
NRF51NVMState *s = NRF51_NVM(dev);
- Error *err = NULL;
- memory_region_init_rom_device(&s->flash, OBJECT(dev), &flash_ops, s,
- "nrf51_soc.flash", s->flash_size, &err);
- if (err) {
- error_propagate(errp, err);
+ if (!memory_region_init_rom_device(&s->flash, OBJECT(dev), &flash_ops, s,
+ "nrf51_soc.flash", s->flash_size,
errp)) {
return;
}
--
2.41.0
- Re: [PATCH-for-9.0 19/25] misc: Simplify qemu_prealloc_mem() calls, (continued)
- [PATCH-for-9.0 20/25] hw: Simplify memory_region_init_ram() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 21/25] hw/arm: Simplify memory_region_init_rom() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 22/25] hw/sparc: Simplify memory_region_init_ram_nomigrate() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 23/25] hw/misc: Simplify memory_region_init_ram_from_fd() calls, Philippe Mathieu-Daudé, 2023/11/20
- [PATCH-for-9.0 24/25] hw/nvram: Simplify memory_region_init_rom_device() calls,
Philippe Mathieu-Daudé <=
- [PATCH-for-9.0 25/25] hw/pci-host/raven: Propagate error in raven_realize(), Philippe Mathieu-Daudé, 2023/11/20