Re: [PATCH-for-9.0 00/16] target/arm/kvm: Unify kvm_arm_FOO() API

[Philippe Mathieu-Daudé]

On 11/12/23 15:36, Peter Maydell wrote:
> On Thu, 23 Nov 2023 at 18:35, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > Half of the API takes CPUState, the other ARMCPU...
> >
> > $ git grep -F 'CPUState *' target/arm/kvm_arm.h | wc -l
> >        16
> > $ git grep -F 'ARMCPU *' target/arm/kvm_arm.h | wc -l
> >        14
> >
> > Since this is ARM specific, have it always take ARMCPU, and
> > call the generic KVM API casting with the CPU() macro.
>
>
>
> Applied to target-arm.next for 9.0, thanks.

Thanks Peter, the only change I added from Gavin review is
on top of patch #3:

-- >8 --
diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
index 6fb8a5f67e..3abbef0260 100644
--- a/target/arm/kvm_arm.h
+++ b/target/arm/kvm_arm.h
@@ -148,7 +148,7 @@ void kvm_arm_set_cpu_features_from_host(ARMCPU *cpu);

 /**
  * kvm_arm_add_vcpu_properties:
- * @obj: The CPU object to add the properties to
+ * @cpu: The CPU object to add the properties to
  *
  * Add all KVM specific CPU properties to the CPU object. These
  * are the CPU properties with "kvm-" prefixed names.
---