Re: [PATCH 23/24] exec/cpu-all: Extract page-protection definitions to page-prot-common.h

[Philippe Mathieu-Daudé]

Hi Nicholas,

On 22/12/23 09:06, Nicholas Piggin wrote:
> On Tue Dec 12, 2023 at 7:20 AM AEST, Philippe Mathieu-Daudé wrote:
> > Extract page-protection definitions from "exec/cpu-all.h"
> > to "exec/page-prot-common.h".
> >
> > The list of files requiring the new header was generated
> > using:
> >
> > $ git grep -wE \
> >    'PAGE_(READ|WRITE|EXEC|BITS|VALID|ANON|RESERVED|TARGET_.|PASSTHROUGH)'
>
> Acked-by: Nicholas Piggin <npiggin@gmail.com> (ppc)
>
> Looks trivial for ppc, so fine. But what's the difference between
> -common.h and -all.h suffix?

We believe historically '-all' was used for target-specific
headers. However then headers got massaged and some ended
using this suffix, although not anymore target specific.

Today for clarity we prefer using '-common' for generic
(target agnostic) headers, and '-target' for target-specific
ones.

I tried to clarify that here:
https://lore.kernel.org/qemu-devel/20231226150441.97501-1-philmd@linaro.org/

Thanks for your review,

Phil.