Re: [PATCH v3 24/46] hw/arm/fsl: use qemu_configure_nic_device()

[Thomas Huth]

On 08/01/2024 21.26, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   hw/arm/fsl-imx25.c  | 2 +-
>   hw/arm/fsl-imx6.c   | 2 +-
>   hw/arm/fsl-imx6ul.c | 2 +-
>   hw/arm/fsl-imx7.c   | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c
> index 9d2fb75a68..a24fa7b443 100644
> --- a/hw/arm/fsl-imx25.c
> +++ b/hw/arm/fsl-imx25.c
> @@ -170,7 +170,7 @@ static void fsl_imx25_realize(DeviceState *dev, Error 
> **errp)
>   
>       object_property_set_uint(OBJECT(&s->fec), "phy-num", s->phy_num,
>                                &error_abort);
> -    qdev_set_nic_properties(DEVICE(&s->fec), &nd_table[0]);
> +    qemu_configure_nic_device(DEVICE(&s->fec), true, NULL);
>   
>       if (!sysbus_realize(SYS_BUS_DEVICE(&s->fec), errp)) {
>           return;
> diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
> index b2153022c0..02f3024090 100644
> --- a/hw/arm/fsl-imx6.c
> +++ b/hw/arm/fsl-imx6.c
> @@ -380,7 +380,7 @@ static void fsl_imx6_realize(DeviceState *dev, Error **errp)
>   
>       object_property_set_uint(OBJECT(&s->eth), "phy-num", s->phy_num,
>                                &error_abort);
> -    qdev_set_nic_properties(DEVICE(&s->eth), &nd_table[0]);
> +    qemu_configure_nic_device(DEVICE(&s->eth), true, NULL);
>       if (!sysbus_realize(SYS_BUS_DEVICE(&s->eth), errp)) {
>           return;
>       }
> diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c
> index e37b69a5e1..ca3dd439ec 100644
> --- a/hw/arm/fsl-imx6ul.c
> +++ b/hw/arm/fsl-imx6ul.c
> @@ -442,7 +442,7 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error 
> **errp)
>                                    s->phy_num[i], &error_abort);
>           object_property_set_uint(OBJECT(&s->eth[i]), "tx-ring-num",
>                                    FSL_IMX6UL_ETH_NUM_TX_RINGS, &error_abort);
> -        qdev_set_nic_properties(DEVICE(&s->eth[i]), &nd_table[i]);
> +        qemu_configure_nic_device(DEVICE(&s->eth[i]), true, NULL);
>           sysbus_realize(SYS_BUS_DEVICE(&s->eth[i]), &error_abort);
>   
>           sysbus_mmio_map(SYS_BUS_DEVICE(&s->eth[i]), 0,
> diff --git a/hw/arm/fsl-imx7.c b/hw/arm/fsl-imx7.c
> index 474cfdc87c..1acbe065db 100644
> --- a/hw/arm/fsl-imx7.c
> +++ b/hw/arm/fsl-imx7.c
> @@ -446,7 +446,7 @@ static void fsl_imx7_realize(DeviceState *dev, Error **errp)
>                                    s->phy_num[i], &error_abort);
>           object_property_set_uint(OBJECT(&s->eth[i]), "tx-ring-num",
>                                    FSL_IMX7_ETH_NUM_TX_RINGS, &error_abort);
> -        qdev_set_nic_properties(DEVICE(&s->eth[i]), &nd_table[i]);
> +        qemu_configure_nic_device(DEVICE(&s->eth[i]), true, NULL);
>           sysbus_realize(SYS_BUS_DEVICE(&s->eth[i]), &error_abort);
>   
>           sysbus_mmio_map(SYS_BUS_DEVICE(&s->eth[i]), 0, FSL_IMX7_ENETn_ADDR[i]);

Reviewed-by: Thomas Huth <thuth@redhat.com>