qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/13] hw/misc/mps2-scc: Factor out which-board conditionals


From: Richard Henderson
Subject: Re: [PATCH 06/13] hw/misc/mps2-scc: Factor out which-board conditionals
Date: Wed, 7 Feb 2024 07:47:39 +1000
User-agent: Mozilla Thunderbird

On 2/6/24 23:29, Peter Maydell wrote:
The MPS SCC device has a lot of different flavours for the various
different MPS FPGA images, which look mostly similar but have
differences in how particular registers are handled.  Currently we
deal with this with a lot of open-coded checks on scc_partno(), but
as we add more board types this is getting a bit hard to read.

Factor out the conditions into some functions which we can
give more descriptive names to.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  hw/misc/mps2-scc.c | 45 +++++++++++++++++++++++++++++++--------------
  1 file changed, 31 insertions(+), 14 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]