[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure
From: |
Jonathan Cameron |
Subject: |
Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure |
Date: |
Tue, 27 Feb 2024 12:53:17 +0000 |
On Fri, 23 Feb 2024 12:42:23 +0000
<ankita@nvidia.com> wrote:
> From: Ankit Agrawal <ankita@nvidia.com>
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
> achieved using Generic Initiator Affinity Structure in SRAT. During bootup,
> Linux kernel parse the ACPI SRAT to determine the PXM ids and create a NUMA
> node for each unique PXM ID encountered. Qemu currently do not implement
> these structures while building SRAT.
>
> Add GI structures while building VM ACPI SRAT. The association between
> device and node are stored using acpi-generic-initiator object. Lookup
> presence of all such objects and use them to build these structures.
>
> The structure needs a PCI device handle [2] that consists of the device BDF.
> The vfio-pci device corresponding to the acpi-generic-initiator object is
> located to determine the BDF.
>
> [1] ACPI Spec 6.3, Section 5.2.16.6
> [2] ACPI Spec 6.3, Table 5.80
>
> Signed-off-by: Ankit Agrawal <ankita@nvidia.com>
> ---
> hw/acpi/acpi-generic-initiator.c | 84 ++++++++++++++++++++++++
> hw/arm/virt-acpi-build.c | 3 +
> include/hw/acpi/acpi-generic-initiator.h | 26 ++++++++
A few more comments.
Maybe _ rather than - as more common for acpi include naming.
I also wonder if we need the acpi prefix for file names given context?
Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure,
Jonathan Cameron <=
[PATCH v7 1/2] qom: new object to associate device to numa node, ankita, 2024/02/23