[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' val
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value |
Date: |
Tue, 27 Feb 2024 18:00:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Igor Mammedov <imammedo@redhat.com> writes:
> later patches will use it to pick SMBIOS version at runtime
> depending on configuration.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> qapi/machine.json | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 93b4677286..4c68528507 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1802,10 +1802,13 @@
> #
> # @64: SMBIOS version 3.0 (64-bit) Entry Point
> #
> +# @auto: Either 2.x or 3.x SMBIOS version, 2.x if configuration can be
> described
> +# by it and 3.x otherwise (since: 9.0)
Please format like
# @auto: Either 2.x or 3.x SMBIOS version, 2.x if configuration can be
# described by it and 3.x otherwise (since: 9.0)
> +#
> # Since: 7.0
> ##
> { 'enum': 'SmbiosEntryPointType',
> - 'data': [ '32', '64' ] }
> + 'data': [ '32', '64', 'auto' ] }
>
> ##
> # @MemorySizeConfiguration:
With that
Acked-by: Markus Armbruster <armbru@redhat.com>
- [PATCH 05/19] smbios: get rid of smbios_smp_sockets global, (continued)
- [PATCH 05/19] smbios: get rid of smbios_smp_sockets global, Igor Mammedov, 2024/02/27
- [PATCH 06/19] smbios: get rid of smbios_legacy global, Igor Mammedov, 2024/02/27
- [PATCH 10/19] smbios: handle errors consistently, Igor Mammedov, 2024/02/27
- [PATCH 09/19] smbios: build legacy mode code only for 'pc' machine, Igor Mammedov, 2024/02/27
- [PATCH 11/19] smbios: clear smbios_tables pointer after freeing, Igor Mammedov, 2024/02/27
- [PATCH 08/19] smbios: don't check type4 structures in legacy mode, Igor Mammedov, 2024/02/27
- [PATCH 12/19] get rid of global smbios_ep_type, Igor Mammedov, 2024/02/27
- [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value, Igor Mammedov, 2024/02/27
- Re: [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value,
Markus Armbruster <=
- [PATCH 15/19] smbios: error out when building type 4 table is not possible, Igor Mammedov, 2024/02/27
- [PATCH 07/19] smbios: avoid mangling user provided tables, Igor Mammedov, 2024/02/27
- [PATCH 14/19] smbios: in case of entry point is 'auto' try to build v2 tables 1st, Igor Mammedov, 2024/02/27
- [PATCH 16/19] smbios: clear smbios_type4_count before building tables, Igor Mammedov, 2024/02/27
- [PATCH 18/19] pc/q35: set SMBIOS entry point type to 'auto' by default, Igor Mammedov, 2024/02/27
- [PATCH 17/19] tests: acpi/smbios: whitelist expected blobs, Igor Mammedov, 2024/02/27
- [PATCH 19/19] tests: acpi: update expected SSDT.dimmpxm blob, Igor Mammedov, 2024/02/27
- Re: [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS, Michael S. Tsirkin, 2024/02/27
- Re: [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS, Fiona Ebner, 2024/02/29