Re: [PATCH v2] tests/functional/aarch64: add tests for FEAT_RME

[Marcin Juszkiewicz]

W dniu 1.12.2024 o 19:09, Pierrick Bouvier pisze:
> Hi Marcin,
>
> On 12/1/24 05:34, Marcin Juszkiewicz wrote:

> > So RME tests probably need longer timeouts or would not run at all.
>
> By any chance, are you running those tests in debug mode?

zOMG, thanks! Turned out that I left "--enable-debug" in my local build 
and forgot to remove it.

90s vs 2974s is a difference ;D

> > > +++ b/tests/functional/test_aarch64_rme_sbsaref.py
> >
> > > +        self.vm.add_args('-accel', 'tcg')
> >
> > That's default value so can be skipped.
> > > +        self.vm.add_args('-m', '2G')
> >
> > I sent patch to bump default memsize to 2G recently.
>
> Is that merged already, or will be later?

Still in review queue.

> > > +        self.vm.add_args('-M', 'sbsa-ref')
> > > +        self.vm.add_args('-drive', 
> > > f'file={pflash0},format=raw,if=pflash')
> > > +        self.vm.add_args('-drive', 
> > > f'file={pflash1},format=raw,if=pflash')
> > > +        self.vm.add_args('-drive', f'file=fat:rw:{virtual},format=raw')
> >
> > > +        self.vm.add_args('-drive', 
> > > f'format=raw,if=none,file={drive},id=hd0')
> > > +        self.vm.add_args('-device', 'virtio-blk-pci,drive=hd0')
> >
> > sbsa-ref is fully emulated target. There is AHCI controller built-in so
> > only "-drive" argument should be needed (no "-device" one).
>
> I followed official instructions from Jean Philippe to build RME stack, 
> and I think it's better to keep them in sync.

OK.

> > > +        self.vm.add_args('-device', 'virtio-net-pci,netdev=net0')
> > > +        self.vm.add_args('-netdev', 'user,id=net0')
> >
> > e1000e is built-in already
>
> This is needed, because without this, there is an explicit wait for a 
> network interface when booting. Adding this device allows to skip it.

Thanks.

> > As both virt and sbsa-ref tests do "more or less" the same stuff then it
> > would be good to make common file/class and reuse it both tests by
> > adding hardware differences.
>
> I was thinking that at the beginning, but most of the config is 
> different. The only common part is the nested guest test.
>
> However, I didn't see any other tests that were importing functions from 
> other files, and since we want to keep those two tests in separate files 
> (to allow parallelism), the most pragmatic solution was to duplicate.

Fetching firmware on sbsa-ref is done in separate to not duplicate it. 
Which gave me idea.

> Overall, tests files should be as simple as possible, even if the price 
> is to repeat a few lines.
> If you have a cleaner solution, I'm open to implement it.