Re: [PATCH 1/7] tests/functional: Introduce a specific test for ast1030 SoC

[Cédric Le Goater]

On 12/6/24 14:48, Thomas Huth wrote:
> On 06/12/2024 14.11, Cédric Le Goater wrote:
> > This simply moves the ast1030 tests to a new test file. No changes.
> >
> > Signed-off-by: Cédric Le Goater <clg@redhat.com>
> > ---
> >   tests/functional/meson.build                |  2 +
> >   tests/functional/test_arm_aspeed.py         | 64 ----------------
> >   tests/functional/test_arm_aspeed_ast1030.py | 81 +++++++++++++++++++++
> >   3 files changed, 83 insertions(+), 64 deletions(-)
> >   create mode 100644 tests/functional/test_arm_aspeed_ast1030.py
> >
> > diff --git a/tests/functional/meson.build b/tests/functional/meson.build
> > index d6d2c0196c76..ef593d4b9928 100644
> > --- a/tests/functional/meson.build
> > +++ b/tests/functional/meson.build
> > @@ -18,6 +18,7 @@ test_timeouts = {
> >     'aarch64_tuxrun' : 240,
> >     'aarch64_virt' : 720,
> >     'acpi_bits' : 420,
> > +  'arm_aspeed_ast1030' : 10,
>
> We've got a default timeout of 90 seconds (see the end of meson.build) ... no 
> need to set a smaller one, so I think you could simply drop this line.

OK. I will drop this change before applying.

> With that line removed:
> Reviewed-by: Thomas Huth <thuth@redhat.com>



Thanks,

C.