qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 17/20] tests/qtest: move clock_steps to after checks


From: Thomas Huth
Subject: Re: [PATCH 17/20] tests/qtest: move clock_steps to after checks
Date: Wed, 11 Dec 2024 07:37:10 +0100
User-agent: Mozilla Thunderbird

On 10/12/2024 21.43, Alex Bennée wrote:
In the qtest environment time will not step forward if the system is
paused (timers disabled) or we have no timer events to fire. As a
result VirtIO events are responded to directly and we don't need to
step time forward.

Potentially the clock_step calls could be removed all together but as
we may implement async behaviour later lets just move them to after
the principle check for now.

Future qtest patches will assert that time actually changes with a

s/with/when/ ?

step is requested.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  tests/qtest/libqos/virtio.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

With the description fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]