Re: [PATCH 67/71] hw/watchdog: Constify all Property

[Cédric Le Goater]

On 12/13/24 20:30, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


For the aspeed part,

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.
> ---
>   hw/watchdog/sbsa_gwdt.c  | 2 +-
>   hw/watchdog/wdt_aspeed.c | 2 +-
>   hw/watchdog/wdt_imx2.c   | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c
> index 80f9b36e79..2e25d4b4e9 100644
> --- a/hw/watchdog/sbsa_gwdt.c
> +++ b/hw/watchdog/sbsa_gwdt.c
> @@ -262,7 +262,7 @@ static void wdt_sbsa_gwdt_realize(DeviceState *dev, Error 
> **errp)
>                   dev);
>   }
>   
> -static Property wdt_sbsa_gwdt_props[] = {
> +static const Property wdt_sbsa_gwdt_props[] = {
>       /*
>        * Timer frequency in Hz. This must match the frequency used by
>        * the CPU's generic timer. Default 62.5Hz matches QEMU's legacy
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 39c3f362a8..c95877e5c7 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -288,7 +288,7 @@ static void aspeed_wdt_realize(DeviceState *dev, Error 
> **errp)
>       sysbus_init_mmio(sbd, &s->iomem);
>   }
>   
> -static Property aspeed_wdt_properties[] = {
> +static const Property aspeed_wdt_properties[] = {
>       DEFINE_PROP_LINK("scu", AspeedWDTState, scu, TYPE_ASPEED_SCU,
>                        AspeedSCUState *),
>       DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/watchdog/wdt_imx2.c b/hw/watchdog/wdt_imx2.c
> index 8162d58afa..61fbd91ee4 100644
> --- a/hw/watchdog/wdt_imx2.c
> +++ b/hw/watchdog/wdt_imx2.c
> @@ -281,7 +281,7 @@ static void imx2_wdt_realize(DeviceState *dev, Error **errp)
>       }
>   }
>   
> -static Property imx2_wdt_properties[] = {
> +static const Property imx2_wdt_properties[] = {
>       DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
>                        false),
>       DEFINE_PROP_END_OF_LIST()