[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 1/5] qapi/qom: Introduce kvm-pmu-filter object
From: |
Zhao Liu |
Subject: |
Re: [RFC v2 1/5] qapi/qom: Introduce kvm-pmu-filter object |
Date: |
Thu, 6 Feb 2025 22:32:25 +0800 |
> Let's ignore how to place it for now, and focus on where we would *like*
> to place it.
>
> Is it related to anything other than ObjectType / ObjectOptions in the
> QMP reference manual?
Yes!
> I guess qapi/kvm.json is for KVM-specific stuff in general, not just the
> KVM PMU filter. Should we have a section for accelerator-specific
> stuff, with subsections for the various accelerators?
>
> [...]
If we consider the accelerator from a top-down perspective, I understand
that we need to add accelerator.json, kvm.json, and kvm-pmu-filter.json.
The first two files are just to include subsections without any additional
content. Is this overkill? Could we just add a single kvm-pmu-filter.json
(I also considered this name, thinking that kvm might need to add more
things in the future)?
Of course, I lack experience with the file organization here. If you think
the three-level sections (accelerator.json, kvm.json, and kvm-pmu-filter.json)
is necessary, I am happy to try this way. :-)