[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian P
From: |
Andreas Färber |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures |
Date: |
Fri, 20 Mar 2015 18:44:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 20.03.2015 um 01:24 schrieb John Snow:
> Two issues were unearthed from ahci-test on ppc64:
>
> (1) The ahci_populate_sglist function had endian issues,
> which is only likely to impact PIO transfers for buffers
> greater than one sector, and
>
> (2) multiple-sector PIO which I attempted to repair in
> 36334faf has been broken for years. ahci-test didn't catch
> this because it used a pattern that was identical for each
> sector.
>
> So the pattern has been corrected and the underlying issue
> fixed.
>
> This should clear up the test failures (properly) for ppc64.
>
> John Snow (4):
> ide: fix cmd_write_pio when nsectors > 1
> ide: fix cmd_read_pio when nsectors > 1
> ahci: Fix sglist offset manipulation for BE machines
> ahci-test: improve rw buffer patterns
Confirming that it resolves the observed failure,
Tested-by: Andreas Färber <address@hidden>
Thanks for the quick fix,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-block] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures, John Snow, 2015/03/19
- [Qemu-block] [PATCH for-2.3 2/4] ide: fix cmd_read_pio when nsectors > 1, John Snow, 2015/03/19
- [Qemu-block] [PATCH for-2.3 3/4] ahci: Fix sglist offset manipulation for BE machines, John Snow, 2015/03/19
- [Qemu-block] [PATCH for-2.3 1/4] ide: fix cmd_write_pio when nsectors > 1, John Snow, 2015/03/19
- [Qemu-block] [PATCH for-2.3 4/4] ahci-test: improve rw buffer patterns, John Snow, 2015/03/19
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures,
Andreas Färber <=
- Re: [Qemu-block] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures, Stefan Hajnoczi, 2015/03/23