[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [RFC PATCH COLO v2 13/13] Don't allow a disk use backing re
From: |
Wen Congyang |
Subject: |
[Qemu-block] [RFC PATCH COLO v2 13/13] Don't allow a disk use backing reference target |
Date: |
Wed, 25 Mar 2015 17:36:14 +0800 |
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gonglei <address@hidden>
---
block.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/block.c b/block.c
index 3af5ad4..548cafa 100644
--- a/block.c
+++ b/block.c
@@ -1399,6 +1399,14 @@ static int
bdrv_open_backing_reference_file(BlockDriverState *bs,
}
backing_hd = blk_bs(backing_blk);
+ /* Don't allow a disk use backing reference target */
+ ret = blk_attach_dev(backing_hd->blk, bs);
+ if (ret < 0) {
+ error_setg(errp, "backing_hd %s is used by the other device model",
+ backing_name);
+ goto free_exit;
+ }
+
/* Backing reference itself? */
if (backing_hd == bs || bdrv_find_overlay(backing_hd, bs)) {
error_setg(errp, "Backing reference itself");
@@ -2077,6 +2085,7 @@ void bdrv_close(BlockDriverState *bs)
if (backing_hd->backing_hd->job) {
block_job_cancel(backing_hd->backing_hd->job);
}
+ blk_detach_dev(backing_hd->backing_hd->blk, bs);
bdrv_set_backing_hd(backing_hd, NULL);
bdrv_unref(backing_hd->backing_hd);
}
--
2.1.0
- Re: [Qemu-block] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS, (continued)
- [Qemu-block] [RFC PATCH COLO v2 10/13] Backup: clear all bitmap when doing block checkpoint, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 07/13] allow writing to the backing file, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 09/13] block: Parse "backing_reference" option to reference existing BDS, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 12/13] skip nbd_target when starting block replication, Wen Congyang, 2015/03/25
- [Qemu-block] [RFC PATCH COLO v2 13/13] Don't allow a disk use backing reference target,
Wen Congyang <=
- [Qemu-block] [RFC PATCH COLO v2 11/13] qcow2: support colo, Wen Congyang, 2015/03/25
- Re: [Qemu-block] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints, Paolo Bonzini, 2015/03/25
- Re: [Qemu-block] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints, Dr. David Alan Gilbert, 2015/03/25