[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage |
Date: |
Mon, 30 Mar 2015 16:25:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Hello Markus et al.,
>
> This series attempts to fix the -device pc87312 issues you reported.
>
> I can't add alias properties for devices that don't get created before
> realize.
> Therefore this involves moving code for various ISA devices, to enable us
> to initialize the objects early for alias properties and realizing them
> as part of the composite device once the configuration is known, also fixing
> error propagation while at it. Probably needs a further iteration.
>
> Yes, it's terribly invasive, that's why the code was as it is.
> But the code movements are quite trivial, as long as no in-air conflicts
> occur.
Pity we have to move the state structs to the header, but that what we
have to do to make them embeddable. And I understand embedding is how
we do sub-devices ("part of" instead of "plugged into").
Your changes are quite regular. They don't look scary to me, but that
could be just ignorance. They're non-trivial enough though to make wary
of merging them for 2.3 this late.
> A follow-up would be to respin my old ISA enabled/disabled series to allow
> inactive ISADevices sitting on an ISABus.
I don't remember this series :)