[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on de
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] block: allow write-threshold on device name |
|
Date: |
Wed, 10 Jun 2015 08:53:48 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/10/2015 07:43 AM, Kevin Wolf wrote:
>
>>> Let's stay away from such magic, as much as we can. libvirt can just
>>> specify a node-name for the protocol layer and use that.
>>
>> Okay, I'll probably abandon this patch, then, but still work on
>> something to make node names easier for libvirt to integrate with.
>
> Hm, okay. I would find it nice to accept device names everywhere where a
> node name is expected (just for aesthetic reasons), but I see that it
> would probably remain unused, so abandoning the patch is okay with me.
For the record, here's the state of the patch that I reached before this
email, which includes documentation and proper device name output - but
the way I implemented it was is a semantic change; so all the more
reason to require node names only for this interface (and avoid the
semantic change). The commit message body is not quite accurate (now
that I've learned more, the active BDS of the device is NOT the node
that libvirt wants, so adding device semantics did not help libvirt), so
much as capturing the state of the patch before I abandon it.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
v2-0001-block-allow-write-threshold-on-device-name.patch
Description: Text Data
signature.asc
Description: OpenPGP digital signature