[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 16/16] ahci: fix sdb fis semantics
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH 16/16] ahci: fix sdb fis semantics |
|
Date: |
Fri, 26 Jun 2015 17:11:12 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 22, 2015 at 08:21:15PM -0400, John Snow wrote:
> @@ -682,19 +680,22 @@ static void ahci_write_fis_sdb(AHCIState *s, int port,
> uint32_t finished)
>
> sdb_fis->type = SATA_FIS_TYPE_SDB;
> /* Interrupt pending & Notification bit */
> - sdb_fis->flags = (ad->hba->control_regs.irqstatus ? (1 << 6) : 0);
> + sdb_fis->flags = 0x40; /* Interrupt bit, always 1 for NCQ */
...
> - ahci_trigger_irq(s, ad, PORT_IRQ_SDB_FIS);
> + if (sdb_fis->flags & 0x40) {
> + ahci_trigger_irq(s, ad, PORT_IRQ_SDB_FIS);
> + }
This if statement is always true.
pgpoxl4q1cHbV.pgp
Description: PGP signature
- Re: [Qemu-block] [PATCH 12/16] ahci: ncq migration, (continued)
[Qemu-block] [PATCH 14/16] ahci: Do not map cmd_fis to generate response, John Snow, 2015/06/22
[Qemu-block] [PATCH 15/16] qtest/ahci: halted ncq migration test, John Snow, 2015/06/22
[Qemu-block] [PATCH 16/16] ahci: fix sdb fis semantics, John Snow, 2015/06/22
- Re: [Qemu-block] [PATCH 16/16] ahci: fix sdb fis semantics,
Stefan Hajnoczi <=
Re: [Qemu-block] [PATCH 00/16] ahci: ncq cleanup, part 2, Stefan Hajnoczi, 2015/06/26