[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PULL v2 39/40] iotests: Add tests for the x-blockdev-d
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PULL v2 39/40] iotests: Add tests for the x-blockdev-del command |
Date: |
Tue, 10 Nov 2015 16:03:02 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 10.11.2015 um 15:59 hat Stefan Hajnoczi geschrieben:
> On Tue, Nov 10, 2015 at 2:09 PM, Kevin Wolf <address@hidden> wrote:
> > From: Alberto Garcia <address@hidden>
> >
> > Signed-off-by: Alberto Garcia <address@hidden>
> > Message-id: address@hidden
> > Reviewed-by: Max Reitz <address@hidden>
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> > tests/qemu-iotests/139 | 414
> > +++++++++++++++++++++++++++++++++++++++++++++
> > tests/qemu-iotests/139.out | 5 +
> > tests/qemu-iotests/group | 1 +
> > 3 files changed, 420 insertions(+)
> > create mode 100644 tests/qemu-iotests/139
> > create mode 100644 tests/qemu-iotests/139.out
>
> I'm seeing the following failure:
>
> ./check -qcow2 139
> QEMU -- "./qemu" -nodefaults
> QEMU_IMG -- "./qemu-img"
> QEMU_IO -- "./qemu-io" -f qcow2 --cache writeback
> QEMU_NBD -- "./qemu-nbd"
> IMGFMT -- qcow2 (compat=1.1)
> IMGPROTO -- file
> PLATFORM -- Linux/x86_64 stefanha-x1 4.2.5-300.fc23.x86_64
> TEST_DIR -- /home/stefanha/qemu/tests/qemu-iotests/scratch
> SOCKET_SCM_HELPER -- /home/stefanha/qemu/tests/qemu-iotests/socket_scm_helper
>
> 139 [failed, exit status 1] - output mismatch (see 139.out.bad)
> --- /home/stefanha/qemu/tests/qemu-iotests/139.out 2015-11-10
> 14:24:03.728322694 +0000
> +++ 139.out.bad 2015-11-10 14:54:51.617899443 +0000
> @@ -1,5 +1,19 @@
> -............
> +........F...
> +======================================================================
> +FAIL: testQuorum (__main__.TestBlockdevDel)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> + File "139", line 403, in testQuorum
> + self.addQuorum('quorum0', 'node0', 'node1')
> + File "139", line 291, in addQuorum
> + self.assert_qmp(result, 'return', {})
> + File "/home/stefanha/qemu/tests/qemu-iotests/iotests.py", line 314,
> in assert_qmp
> + result = self.dictpath(d, path)
> + File "/home/stefanha/qemu/tests/qemu-iotests/iotests.py", line 293,
> in dictpath
> + self.fail('failed path traversal for "%s" in "%s"' % (path, str(d)))
> +AssertionError: failed path traversal for "return" in "{u'error':
> {u'class': u'GenericError', u'desc': u"Unknown driver 'quorum'"}}"
> +
I guess we need a follow-up patch for -rc1 that simply skips the test
case if quorum isn't available.
Kevin
- [Qemu-block] [PULL v2 32/40] qemu-io: Check for trailing chars, (continued)
- [Qemu-block] [PULL v2 32/40] qemu-io: Check for trailing chars, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 31/40] qemu-io: fix cvtnum lval types, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 36/40] mirror: block all operations on the target image during the job, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 30/40] block: test 'blockdev-snapshot' using a file BDS as the overlay, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 34/40] qemu-iotests: fix cleanup of background processes, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 33/40] qemu-io: Correct error messages, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 35/40] qemu-iotests: fix -valgrind option for check, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 37/40] block: Add blk_get_refcnt(), Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 39/40] iotests: Add tests for the x-blockdev-del command, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 38/40] block: Add 'x-blockdev-del' QMP command, Kevin Wolf, 2015/11/10
- [Qemu-block] [PULL v2 40/40] qcow2: Fix qcow2_get_cluster_offset() for zero clusters, Kevin Wolf, 2015/11/10
- Re: [Qemu-block] [Qemu-devel] [PULL v2 00/40] Block layer patches, Peter Maydell, 2015/11/10