[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 13/21] block: Introduce bs->explicit_options
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 13/21] block: Introduce bs->explicit_options |
Date: |
Fri, 27 Nov 2015 19:38:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 23.11.2015 16:59, Kevin Wolf wrote:
> bs->options doesn't only contain options that the user explicitly
> requested, but also option that were derived from flags, the filename or
> inherited from the parent node.
>
> For reopen, it is important to know the difference because reopening the
> parent can change inherited values in child nodes, but it shouldn't
> change any options that were explicitly specified for the child.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 24 ++++++++++++++++++++++--
> include/block/block.h | 1 +
> include/block/block_int.h | 1 +
> 3 files changed, 24 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 10/21] block: reopen: Document option precedence and refactor accordingly, (continued)
- [Qemu-block] [PATCH v2 10/21] block: reopen: Document option precedence and refactor accordingly, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 12/21] block: Split out parse_json_protocol(), Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 08/21] block: Keep "driver" in bs->options, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 14/21] blockdev: Set 'format' indicates non-empty drive, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 04/21] block: Allow references for backing files, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 13/21] block: Introduce bs->explicit_options, Kevin Wolf, 2015/11/23
- Re: [Qemu-block] [PATCH v2 13/21] block: Introduce bs->explicit_options,
Max Reitz <=
- [Qemu-block] [PATCH v2 16/21] block: reopen: Extract QemuOpts for generic block layer options, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 15/21] qemu-iotests: Remove cache mode test without medium, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 11/21] block: Add infrastructure for option inheritance, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 17/21] block: Move cache options into options QDict, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 18/21] blkdebug: Enable reopen, Kevin Wolf, 2015/11/23
- [Qemu-block] [PATCH v2 19/21] qemu-iotests: Try setting cache mode for children, Kevin Wolf, 2015/11/23