[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v7 11/20] block: Don't lock drive-backup target imag
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH v7 11/20] block: Don't lock drive-backup target image in none mode |
Date: |
Mon, 8 Aug 2016 21:13:24 +0800 |
As a very special case, in sync=none mode, the source is the backing image of
the target, which will be RO opened again. This won't work with image locking
because the first open could be exclusive.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
blockdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index a9032b9..55b0fde 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3233,6 +3233,11 @@ static void do_drive_backup(const char *job_id, const
char *device,
}
}
if (sync == MIRROR_SYNC_MODE_NONE) {
+ /* XXX: bs will be open second time as the backing file of target,
+ * disable image locking. Once block layer allows sharing backing BDS,
+ * change below to BDRV_O_NO_BACKING and assign it after bdrv_open().
+ **/
+ flags |= BDRV_O_NO_LOCK;
source = bs;
}
--
2.7.4
- [Qemu-block] [PATCH v7 01/20] block: Add flag bits for image locking, (continued)
- [Qemu-block] [PATCH v7 01/20] block: Add flag bits for image locking, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 02/20] qapi: Add lock-mode in blockdev-add options, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 03/20] block: Add and parse "lock-mode" option for image locking, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 04/20] block: Introduce image file locking, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 05/20] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 06/20] raw-posix: Add image locking support, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 07/20] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 08/20] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 09/20] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 10/20] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 11/20] block: Don't lock drive-backup target image in none mode,
Fam Zheng <=
- [Qemu-block] [PATCH v7 12/20] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 13/20] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 15/20] iotests: 087: Disable image locking in cases where file is shared, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 16/20] iotests: 130: Check image info locklessly, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 19/20] block: Turn on image locking by default, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 17/20] iotests: Disable image locking in 085, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 18/20] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 20/20] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2016/08/08
- [Qemu-block] [PATCH v7 14/20] qemu-iotests: 030: Disable image locking when checking test image, Fam Zheng, 2016/08/08
- Re: [Qemu-block] [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8, no-reply, 2016/08/08