Re: [Qemu-block] [PATCH v4 1/9] util: Add UUID API

[Richard Henderson]

On 08/11/2016 05:50 AM, Fam Zheng wrote:
> +void qemu_uuid_bswap(QemuUUID *uuid)
> +{
> +    bswap32s((uint32_t *)&uuid->data[0]);
> +    bswap16s((uint16_t *)&uuid->data[4]);
> +    bswap16s((uint16_t *)&uuid->data[6]);
> +}

You have alignment problems here too.  Perhaps you really did want to add 
uint32_t (and uint16_t?) as union members to QemuUUID.


r~