[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v5 5/9] crypto: Switch to QEMU UUID API
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH v5 5/9] crypto: Switch to QEMU UUID API |
Date: |
Fri, 12 Aug 2016 12:52:12 +0800 |
The uuid generation doesn't return error, so update the function
signature and calling code accordingly.
Signed-off-by: Fam Zheng <address@hidden>
---
crypto/block-luks.c | 26 +++++++-------------------
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/crypto/block-luks.c b/crypto/block-luks.c
index aba4455..da65dc0 100644
--- a/crypto/block-luks.c
+++ b/crypto/block-luks.c
@@ -29,10 +29,7 @@
#include "crypto/pbkdf.h"
#include "crypto/secret.h"
#include "crypto/random.h"
-
-#ifdef CONFIG_UUID
-#include <uuid/uuid.h>
-#endif
+#include "qemu/uuid.h"
#include "qemu/coroutine.h"
@@ -877,18 +874,12 @@ qcrypto_block_luks_open(QCryptoBlock *block,
}
-static int
-qcrypto_block_luks_uuid_gen(uint8_t *uuidstr, Error **errp)
+static void
+qcrypto_block_luks_uuid_gen(uint8_t *uuidstr)
{
-#ifdef CONFIG_UUID
- uuid_t uuid;
- uuid_generate(uuid);
- uuid_unparse(uuid, (char *)uuidstr);
- return 0;
-#else
- error_setg(errp, "Unable to generate uuids on this platform");
- return -1;
-#endif
+ QemuUUID uuid;
+ qemu_uuid_generate(&uuid);
+ qemu_uuid_unparse(&uuid, (char *)uuidstr);
}
static int
@@ -961,10 +952,7 @@ qcrypto_block_luks_create(QCryptoBlock *block,
* it out to disk
*/
luks->header.version = QCRYPTO_BLOCK_LUKS_VERSION;
- if (qcrypto_block_luks_uuid_gen(luks->header.uuid,
- errp) < 0) {
- goto error;
- }
+ qcrypto_block_luks_uuid_gen(luks->header.uuid);
cipher_alg = qcrypto_block_luks_cipher_alg_lookup(luks_opts.cipher_alg,
errp);
--
2.7.4
- [Qemu-block] [PATCH v5 0/9] UUID clean ups for 2.8, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 1/9] util: Add UUID API, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 2/9] vhdx: Use QEMU UUID API, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 3/9] vdi: Use QEMU UUID API, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 4/9] vpc: Use QEMU UUID API, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 5/9] crypto: Switch to QEMU UUID API,
Fam Zheng <=
- [Qemu-block] [PATCH v5 6/9] tests: No longer dependent on CONFIG_UUID, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 7/9] configure: Remove detection code for UUID, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 9/9] tests: Add uuid tests, Fam Zheng, 2016/08/12
- [Qemu-block] [PATCH v5 8/9] vl: Switch qemu_uuid to QemuUUID, Fam Zheng, 2016/08/12
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/9] UUID clean ups for 2.8, no-reply, 2016/08/12