[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime option
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options |
Date: |
Fri, 12 Aug 2016 19:15:47 +0200 |
The SSH and NBD block drivers currently directly extract their runtime
options from the options QDict they receive. This is bad practice and
can lead to segmentation faults (which, however, will always be a NULL
pointer dereference, so it should not be exploitable beyond a DoS).
This series fixes that by using QemuOpts instead (like all the other
block drivers do).
With this series applied, there are only two instances of "qdict_get"
left in block/, both of which appear to be safe.
Max Reitz (5):
block/ssh: Use QemuOpts for runtime options
block/nbd: Use QemuOpts for runtime options
block/blkdebug: Store config filename
block/nbd: Store runtime option values
iotests: Test case for wrong runtime option types
block/blkdebug.c | 17 +++--
block/nbd.c | 159 ++++++++++++++++++++++++++++++---------------
block/ssh.c | 77 +++++++++++++++-------
tests/qemu-iotests/162 | 96 +++++++++++++++++++++++++++
tests/qemu-iotests/162.out | 17 +++++
tests/qemu-iotests/group | 1 +
6 files changed, 284 insertions(+), 83 deletions(-)
create mode 100755 tests/qemu-iotests/162
create mode 100644 tests/qemu-iotests/162.out
--
2.9.2
- [Qemu-block] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options,
Max Reitz <=
- [Qemu-block] [PATCH for-2.7? 3/5] block/blkdebug: Store config filename, Max Reitz, 2016/08/12
- [Qemu-block] [PATCH for-2.7? 1/5] block/ssh: Use QemuOpts for runtime options, Max Reitz, 2016/08/12
- [Qemu-block] [PATCH for-2.7? 4/5] block/nbd: Store runtime option values, Max Reitz, 2016/08/12
- [Qemu-block] [PATCH for-2.7? 5/5] iotests: Test case for wrong runtime option types, Max Reitz, 2016/08/12
- [Qemu-block] [PATCH for-2.7? 2/5] block/nbd: Use QemuOpts for runtime options, Max Reitz, 2016/08/12
- Re: [Qemu-block] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options, Kevin Wolf, 2016/08/15