Re: [Qemu-block] [PATCH v24 11/12] support replication driver in blockdev-add

[Changlong Xie]

On 08/15/2016 04:37 PM, Kevin Wolf wrote:
> Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben:
> > On 08/09/2016 05:08 PM, Kevin Wolf wrote:
> > > Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben:
> > > > From: Wen Congyang <address@hidden>
> > > >
> > > > Signed-off-by: Wen Congyang <address@hidden>
> > > > Signed-off-by: Changlong Xie <address@hidden>
> > > > Signed-off-by: Wang WeiWei <address@hidden>
> > > > Signed-off-by: zhanghailiang <address@hidden>
> > > > Signed-off-by: Gonglei <address@hidden>
> > > > Reviewed-by: Eric Blake <address@hidden>
> > >
> > > > @@ -2078,6 +2079,23 @@
> > > >   { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
> > > >
> > > >   ##
> > > > +# @BlockdevOptionsReplication
> > > > +#
> > > > +# Driver specific block device options for replication
> > > > +#
> > > > +# @mode: the replication mode
> > > > +#
> > > > +# @top-id: #optional In secondary mode, node name or device ID of the root
> > > > +#          node who owns the replication node chain. Ignored in primary mode.
> > >
> > > Can we change this to "Must not be given in primary mode"? Not sure what
> > > the code currently does, but I think it should error out if top-id is
> >
> > Replication driver will ignore "top-id" parameter in Primary mode.
>
> This is not good behaviour, which is why I requested a change.

Hi stefan

Would you like me send another [PATCH v25] based your block-next? Or a 
separate patch until your tree is merged.

Thanks
        -Xie

> Kevin
>
> > > given there.
> > >
> > > > +#
> > > > +# Since: 2.8
> > > > +##
> > > > +{ 'struct': 'BlockdevOptionsReplication',
> > > > +  'base': 'BlockdevOptionsGenericFormat',
> > > > +  'data': { 'mode': 'ReplicationMode',
> > > > +            '*top-id': 'str' } }
> > >
> > > Kevin
>
>
> .