qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] iotest 055: refactor and speed up


From: Pavel Butsykin
Subject: Re: [Qemu-block] [PATCH v2] iotest 055: refactor and speed up
Date: Tue, 16 Aug 2016 14:44:21 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 09.08.2016 16:15, Vladimir Sementsov-Ogievskiy wrote:
Source disk is created and filled with test data before each test case.
Instead initialize it once for the whole unit.

Test disk filling patterns are merged into one pattern.

Also TestSetSpeed used different image_len for source and target (by
mistake) - this is automatically fixed here.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---

v2: rebase on block-next, as compression test pattern differs, merge patterns.

Need review from Pavel, is new merged disk filling pattern ok for you?

Also, removed from commit message performance measurements. On block-next this 
test
is too long for other reasons, so for qcow speed is not such significant: for 
qcow2
I have 7min:33s -> 6min:45s.


  tests/qemu-iotests/055 | 52 +++++++++++++++++---------------------------------
  1 file changed, 18 insertions(+), 34 deletions(-)


Reviewed-by: Pavel Butsykin <address@hidden>

But unfortunately, here the main slowing factor is vmdk compression.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]