Re: [Qemu-block] [Qemu-devel] [PATCH for-2.8] iotests: Do not rely on unavailable domains in 162

[Sascha Silbe]

Dear Max,

Max Reitz <address@hidden> writes:

> On 2016-08-23 at 07:44, Sascha Silbe wrote:
>> Max Reitz <address@hidden> writes:
[tests/qemu-iotests/162]
>> Using a fixed port number means multiple users won't be able to run this
>> in parallel. That it's only open for a short time actually makes the
>> issue a bit worse as it's hard to understand just why the test failed
>> intermittently.
>>
>> Is there a way to have qemu-nbd use a random port and print the port
>> number?
>
> Good idea. We can just let the script generate a random port; 
> $(($RANDOM+32768)) should do the trick.

Which will fail just the same as the original version if anything (not
just qemu-nbd) is already occupying the port you happened to
choose.

Maybe we should just fix this part:

>>> +# (We need to set up a server here, because the error message for 
>>> "Connection
>>> +#  refused" does not contain the destination port)

Including the port number in the "Connection refused" error message is a
useful diagnostic, especially if it's a non-default port.

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641